Migrate Remoting Webapp Unittests to use QUnit 2.0 syntax.

remoting/webapp/crd/js/error_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
 QUnit.module('error', {
-  setup: function() {
+  beforeEach: function() {
   },
-  teardown: function() {
+  afterEach: function() {
   }

[Jamie, 2015/03/17 17:57:15]

Can you just remove these empty functions?

[kelvinp, 2015/03/17 18:13:58]

Done.

 });
 
 QUnit.test('error constructor 1', function() {
   var error = new remoting.Error(remoting.Error.Tag.HOST_OVERLOAD);
   QUnit.equal(error.getTag(), remoting.Error.Tag.HOST_OVERLOAD);
   QUnit.equal(error.toString(), remoting.Error.Tag.HOST_OVERLOAD);
 });
 
 QUnit.test('error constructor 2', function() {
   var error = new remoting.Error(
       remoting.Error.Tag.HOST_IS_OFFLINE,
       'detail');
   QUnit.equal(error.getTag(), remoting.Error.Tag.HOST_IS_OFFLINE);
   QUnit.ok(error.toString().indexOf(remoting.Error.Tag.HOST_IS_OFFLINE) != -1);
   QUnit.ok(error.toString().indexOf('detail') != -1);
 });
 
 QUnit.test('hasTag', function() {
   var error = new remoting.Error(remoting.Error.Tag.HOST_OVERLOAD);
-  QUnit.ok(error.hasTag(remoting.Error.Tag.HOST_OVERLOAD));
-  QUnit.ok(error.hasTag(
-    remoting.Error.Tag.HOST_OVERLOAD,
-    remoting.Error.Tag.HOST_IS_OFFLINE));
-  QUnit.ok(!error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE));
+   QUnit.ok(error.hasTag(remoting.Error.Tag.HOST_OVERLOAD));
+   QUnit.ok(error.hasTag(
+     remoting.Error.Tag.HOST_OVERLOAD,
+     remoting.Error.Tag.HOST_IS_OFFLINE));
+   QUnit.ok(!error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE));

[Jamie, 2015/03/17 17:57:16]

Indentation.

[kelvinp, 2015/03/17 18:13:58]

Done.

 });
 
 QUnit.test('constructor methods', function() {
   QUnit.ok(remoting.Error.none().hasTag(remoting.Error.Tag.NONE));
   QUnit.ok(remoting.Error.unexpected().hasTag(remoting.Error.Tag.UNEXPECTED));
 });
 
 QUnit.test('isNone', function() {
   QUnit.ok(remoting.Error.none().isNone());
   QUnit.ok(!remoting.Error.unexpected().isNone());
@@ skipping 60 matching lines @@
   var reportedError;
   var onError = function(/** !remoting.Error */ arg) {
     reportedError = arg;
   };
   var origError = new remoting.Error(remoting.Error.Tag.HOST_IS_OFFLINE);
   remoting.Error.handler(onError)(origError);
   QUnit.equal(reportedError, origError);
 });
 
 })();