Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 10176003: Set svn:executable bit on scripts that are executable. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Set svn:executable bit only on scripts that are executable. Removes the svn:executable bit on non-executable python files. R=scherkus@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-11 lines, --9 lines) Patch
A media/tools/bug_hunter/bug_hunter.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/tools/bug_hunter/bug_hunter_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/bug_hunter/bug_hunter_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
A media/tools/constrained_network_server/traffic_control.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/constrained_network_server/traffic_control_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/constrained_network_server/traffic_control_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/layouttest_analyzer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/layouttest_analyzer_runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/layouttests_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/test_expectations_history_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/test_expectations_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A media/tools/layout_tests/trend_graph_unittest.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-23 02:04:39 UTC) #1
DaleCurtis
On 2012/04/23 02:04:39, Marc-Antoine Ruel wrote: traffic_control.py is a library, so shouldn't be +x.
8 years, 8 months ago (2012-04-23 16:27:16 UTC) #2
M-A Ruel
On 2012/04/23 16:27:16, DaleCurtis wrote: > On 2012/04/23 02:04:39, Marc-Antoine Ruel wrote: > > traffic_control.py ...
8 years, 8 months ago (2012-04-23 16:30:15 UTC) #3
DaleCurtis
Nice! Thanks for doing this. These are all testing files, so lgtm to me.
8 years, 8 months ago (2012-04-23 17:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10176003/1
8 years, 8 months ago (2012-04-23 17:32:33 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:24:59 UTC) #6
Change committed as 133493

Powered by Google App Engine
This is Rietveld 408576698