Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1017593003: Fix for making popup size proper when we have 'Block third-party cookies and site data' checkbox en… (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for making popup size proper when we have 'Block third-party cookies and site data' checkbox enabled. string for IDS_COLLECTED_COOKIES_BLOCKED_THIRD_PARTY_BLOCKING_ENABLED is not getting wrapped, so the popup size is getting set to largest string size so making big poup un-necessarily. Now string will get wrapped by the size of the treeviewwidth so we will get the same size of popup when checkbox is checked as well as when checkbox is not checked cases. BUG=467503 Committed: https://crrev.com/2764ed907d5c43614d287b4a5c39a80e88782c53 Cr-Commit-Position: refs/heads/master@{#321296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Deepak
@msw PTAL, Simple change to wrap the string by popup size(TreeViewWidth) so that same width ...
5 years, 9 months ago (2015-03-17 08:58:38 UTC) #2
msw
This should be okay, but please upload screenshots of the blocked cookies tab before and ...
5 years, 9 months ago (2015-03-17 21:24:57 UTC) #3
Deepak
On 2015/03/17 21:24:57, msw wrote: > This should be okay, but please upload screenshots of ...
5 years, 9 months ago (2015-03-18 04:57:47 UTC) #4
msw
lgtm
5 years, 9 months ago (2015-03-18 16:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017593003/1
5 years, 9 months ago (2015-03-19 02:44:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 04:53:31 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:54:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2764ed907d5c43614d287b4a5c39a80e88782c53
Cr-Commit-Position: refs/heads/master@{#321296}

Powered by Google App Engine
This is Rietveld 408576698