Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1017563003: Hook up AppLifeTimeManager::Observer to turn off discoverability for Smart Lock. (Closed)

Created:
5 years, 9 months ago by Tim Song
Modified:
5 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up AppLifeTimeManager::Observer to turn off discoverability for Smart Lock. BUG=chromium:442831 Committed: https://crrev.com/bc93da2f8d6126e2b07882a5770f18c7c6ccee3f Cr-Commit-Position: refs/heads/master@{#320879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tim Song
My bad. I forgot to hook this up in the previous CL.
5 years, 9 months ago (2015-03-17 01:50:58 UTC) #2
xiyuan
lgtm
5 years, 9 months ago (2015-03-17 02:55:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017563003/1
5 years, 9 months ago (2015-03-17 06:28:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 07:33:07 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 07:33:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc93da2f8d6126e2b07882a5770f18c7c6ccee3f
Cr-Commit-Position: refs/heads/master@{#320879}

Powered by Google App Engine
This is Rietveld 408576698