Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 101753005: Changes to interpret the optimizable bit based on whether the function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/bigint_operations.h" 9 #include "vm/bigint_operations.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 1258 matching lines...) Expand 10 before | Expand all | Expand 10 after
1269 break; 1269 break;
1270 } 1270 }
1271 token = strtok_r(NULL, ",", &save_ptr); 1271 token = strtok_r(NULL, ",", &save_ptr);
1272 } 1272 }
1273 delete[] filter; 1273 delete[] filter;
1274 if (!found) { 1274 if (!found) {
1275 function.set_usage_counter(kLowInvocationCount); 1275 function.set_usage_counter(kLowInvocationCount);
1276 return false; 1276 return false;
1277 } 1277 }
1278 } 1278 }
1279 if (!function.is_optimizable()) { 1279 if (!function.IsOptimizable()) {
1280 if (FLAG_trace_failed_optimization_attempts) { 1280 if (FLAG_trace_failed_optimization_attempts) {
1281 OS::PrintErr("Not Optimizable: %s\n", function.ToFullyQualifiedCString()); 1281 OS::PrintErr("Not Optimizable: %s\n", function.ToFullyQualifiedCString());
1282 } 1282 }
1283 // TODO(5442338): Abort as this should not happen. 1283 // TODO(5442338): Abort as this should not happen.
1284 function.set_usage_counter(kLowInvocationCount); 1284 function.set_usage_counter(kLowInvocationCount);
1285 return false; 1285 return false;
1286 } 1286 }
1287 return true; 1287 return true;
1288 } 1288 }
1289 1289
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
1715 // of the given value. 1715 // of the given value.
1716 // Arg0: Field object; 1716 // Arg0: Field object;
1717 // Arg1: Value that is being stored. 1717 // Arg1: Value that is being stored.
1718 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) { 1718 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
1719 const Field& field = Field::CheckedHandle(arguments.ArgAt(0)); 1719 const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
1720 const Object& value = Object::Handle(arguments.ArgAt(1)); 1720 const Object& value = Object::Handle(arguments.ArgAt(1));
1721 field.UpdateGuardedCidAndLength(value); 1721 field.UpdateGuardedCidAndLength(value);
1722 } 1722 }
1723 1723
1724 } // namespace dart 1724 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698