Update painting code for AutocompletePoupContentsView for high DPI

In high DPI mode, we need to be careful whenever we use intermediate bitmaps for painting. In the case of the omnibox we were drawing into a non scaled intermediate bitmap which is then drawn to a scaled destination bitmap.
This yielded an ugly 2x pixelated look.

In this patch, we remove the intermediate bitmap all together as it seems no longer necessary

Bug=None
Test=Non pixelated @ 2x scale

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136028

[pkotwicz, 2012-04-22 18:57:47]

Mike, can you verify that the concerns expressed in the code comments are not
valid now that Skia supports clipping with antialiasing

I checked my implementation with the magnifier and couldn't see any "jagged
edges"

[pkotwicz, 2012-04-27 21:16:06]

Ping!

[pkotwicz, 2012-04-27 21:16:32]

Ping!

[reed1, 2012-04-30 20:45:06]

lgtm

don't understand all of the context, but that is the right way (it seems) to use
the new soft-clipping feature.

[pkotwicz, 2012-04-30 20:50:48]

msw can you take a look that I didn't miss anything?

[msw, 2012-05-04 23:50:38]

+Ben for review; PTAL.

Sorry that this fell off my plate; I'm only on annotate/blame for reordering
this code in crrev.com/78416. Looks like Ben is probably the best reviewer here:

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/autoc...

[Ben Goodger (Google), 2012-05-07 15:29:45]

http://codereview.chromium.org/10175001/diff/1/chrome/browser/ui/views/autoco...
File chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
(right):

http://codereview.chromium.org/10175001/diff/1/chrome/browser/ui/views/autoco...
chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc:390:
true /* doAntialias */);
Won't this result in a jagged edge?

We use drawPath because it is anti-aliased.

[Ben Goodger (Google), 2012-05-07 15:30:03]

Or is that what soft clipping does?

[pkotwicz, 2012-05-07 16:01:22]

Soft clipping does antialiasing

[Ben Goodger (Google), 2012-05-07 16:50:35]

On 2012/05/07 16:01:22, pkotwicz wrote:
> Soft clipping does antialiasing

Cool! LGTM.

[commit-bot: I haz the power, 2012-05-09 00:04:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10175001/1

[commit-bot: I haz the power, 2012-05-09 00:38:44]

Try job failure for 10175001-1 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-09 02:18:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10175001/15002

[commit-bot: I haz the power, 2012-05-09 03:39:53]

Try job failure for 10175001-15002 (retry) on linux_rel for step
"browser_tests".
It's a second try, previously, steps "base_unittests, browser_tests,
net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-05-09 05:08:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10175001/15002

[commit-bot: I haz the power, 2012-05-09 08:30:16]

Try job failure for 10175001-15002 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...