Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1017473002: [Merge] Make mouse buttons 8 - 11 navigate forward and back in history (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Make mouse buttons 8 - 11 navigate forward and back in history This CL: - Introduces the EF_BACK_MOUSE_BUTTON and EF_FORWARD_MOUSE_BUTTON event flags. - Removes X11 dependencies from BrowserCommandHandlerX11 and makes it used on Ozone and X11 - Removes the X11 specific handling from BrowserCommandHandlerX11 - Makes Ozone set the ui::EF_BACK_MOUSE_BUTTON flag for BTN_SIDE and BTN_BACK - Makes Ozone set the ui::EF_FORWARD_MOUSE_BUTTON flag for BTN_EXTRA and BTN_FORWARD BUG=462907 TEST=Manual, see bug TBR=pkotwicz Committed: https://chromium.googlesource.com/chromium/src/+/a387666a84a493303583d92e653a55bd17ad99ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -148 lines) Patch
A + chrome/browser/ui/views/frame/browser_command_handler_linux.h View 2 chunks +7 lines, -8 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_command_handler_linux.cc View 1 chunk +53 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_command_handler_x11.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_command_handler_x11.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/event.h View 5 chunks +11 lines, -8 lines 0 comments Download
M ui/events/event_constants.h View 1 chunk +19 lines, -15 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 3 chunks +29 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_modifiers_evdev.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_modifiers_evdev.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 5 chunks +27 lines, -16 lines 0 comments Download
M ui/events/x/events_x.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pkotwicz
5 years, 9 months ago (2015-03-16 20:29:13 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a387666a84a493303583d92e653a55bd17ad99ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698