Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1017463002: Fix some checked mode errors in drawer.dart (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix some checked mode errors in drawer.dart We need to use the more generic type Curve. Also, added an assert to catch this earlier. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/372a4fe3edb69652c75f5ebe2de497818b017da5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sky/framework/animation/generators.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sky/framework/components/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-16 19:56:15 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-03-16 19:56:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
372a4fe3edb69652c75f5ebe2de497818b017da5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698