Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1017453008: Make GetAlternateProtocol return AlternativeService. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GetAlternateProtocol return AlternativeService. Make HttpServerProperties::GetAlternateProtocol return AlternativeService, and rename it to GetAlternativeService. Rename its parameter, as well as parameters of other alternate protocol or alternative service related functions, from server to origin. Update all clients of GetAlternateProtocol. Also rename anonymous namespace HasAlternateProtocol to HasAlternativeService in tests. BUG=392576 Committed: https://crrev.com/181b39ad8041a4c7655ddff7c328db3cb4cf3e07 Cr-Commit-Position: refs/heads/master@{#320980}

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Total comments: 2

Patch Set 3 : s/server/origin/g in other methods too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -191 lines) Patch
M net/http/http_network_transaction_unittest.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M net/http/http_server_properties.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 6 chunks +34 lines, -38 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 14 chunks +59 lines, -60 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 9 chunks +24 lines, -25 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan, please take a look. Thank you.
5 years, 9 months ago (2015-03-17 16:49:08 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1017453008/diff/20001/net/http/http_server_properties.h File net/http/http_server_properties.h (right): https://codereview.chromium.org/1017453008/diff/20001/net/http/http_server_properties.h#newcode212 net/http/http_server_properties.h:212: const HostPortPair& origin) = 0; Can you fix ...
5 years, 9 months ago (2015-03-17 19:45:42 UTC) #3
Bence
Thank you. https://codereview.chromium.org/1017453008/diff/20001/net/http/http_server_properties.h File net/http/http_server_properties.h (right): https://codereview.chromium.org/1017453008/diff/20001/net/http/http_server_properties.h#newcode212 net/http/http_server_properties.h:212: const HostPortPair& origin) = 0; On 2015/03/17 ...
5 years, 9 months ago (2015-03-17 20:00:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017453008/40001
5 years, 9 months ago (2015-03-17 20:01:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 21:36:56 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:37:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/181b39ad8041a4c7655ddff7c328db3cb4cf3e07
Cr-Commit-Position: refs/heads/master@{#320980}

Powered by Google App Engine
This is Rietveld 408576698