src/IceGlobalContext.cpp - Issue 1017453007: Subzero: Support non sequentially consistent memory orderings for atomic ops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 1017453007: Subzero: Support non sequentially consistent memory orderings for atomic ops. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More code review cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index 8f20129ea383aad1a0bb524097e8a3babc679c39..6badc559aa9236b017ad9ad262d216812c0e25d4 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -195,7 +195,8 @@ void GlobalContext::translateFunctions() {

if (Func->hasError()) {

getErrorStatus()->assign(EC_Translation);

OstreamLocker L(this);

- getStrDump() << "ICE translation error: " << Func->getError() << "\n";

+ getStrDump() << "ICE translation error: " << Func->getFunctionName()

+ << ": " << Func->getError() << "\n";

Item = new EmitterWorkItem(Func->getSequenceNumber());

} else {

Func->getAssembler<>()->setInternal(Func->getInternal());

« no previous file with comments | « no previous file | src/IceIntrinsics.h » ('j') | no next file with comments »