Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1017453006: ServiceWorker: Merge FindSWRegistration into FindOrCreateRegistration for cleanup (Closed)

Created:
5 years, 9 months ago by nhiroki
Modified:
5 years, 9 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@refcount_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Merge FindSWRegistration into FindOrCreateRegistration for cleanup BUG=452403 TEST=content_unittests --gtest_filter=ServiceWorkerDispatcherTest.* Committed: https://crrev.com/d1f1bb1241c5e31e5373e1d77876ea2537c91c6a Cr-Commit-Position: refs/heads/master@{#320902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 2 chunks +5 lines, -8 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 2 chunks +12 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
ptal, thanks!
5 years, 9 months ago (2015-03-17 08:23:49 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 9 months ago (2015-03-17 08:37:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017453006/1
5 years, 9 months ago (2015-03-17 11:34:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 12:38:45 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 12:39:19 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d1f1bb1241c5e31e5373e1d77876ea2537c91c6a
Cr-Commit-Position: refs/heads/master@{#320902}

Powered by Google App Engine
This is Rietveld 408576698