Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: net/proxy/mojo_proxy_resolver_factory_impl.cc

Issue 1017453005: Add support for ProxyResolverErrorObserver to ProxyResolverMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/proxy/mojo_proxy_resolver_factory_impl.h" 5 #include "net/proxy/mojo_proxy_resolver_factory_impl.h"
6 6
7 #include "net/dns/host_resolver_mojo.h" 7 #include "net/dns/host_resolver_mojo.h"
8 #include "net/proxy/mojo_proxy_resolver_impl.h" 8 #include "net/proxy/mojo_proxy_resolver_impl.h"
9 #include "net/proxy/proxy_resolver_error_observer_mojo.h"
9 #include "net/proxy/proxy_resolver_v8.h" 10 #include "net/proxy/proxy_resolver_v8.h"
10 #include "net/proxy/proxy_resolver_v8_tracing.h" 11 #include "net/proxy/proxy_resolver_v8_tracing.h"
11 #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" 12 #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h"
12 13
13 namespace net { 14 namespace net {
14 namespace { 15 namespace {
15 16
16 scoped_ptr<ProxyResolver> CreateDefaultProxyResolver( 17 scoped_ptr<ProxyResolver> CreateDefaultProxyResolver(
17 HostResolver* host_resolver, 18 HostResolver* host_resolver,
19 scoped_ptr<ProxyResolverErrorObserver> error_observer,
18 const ProxyResolver::LoadStateChangedCallback& callback) { 20 const ProxyResolver::LoadStateChangedCallback& callback) {
19 return make_scoped_ptr( 21 return make_scoped_ptr(new ProxyResolverV8Tracing(
20 new ProxyResolverV8Tracing(host_resolver, nullptr, nullptr, callback)); 22 host_resolver, error_observer.release(), nullptr, callback));
21 } 23 }
22 24
23 // A class to manage the lifetime of a MojoProxyResolverImpl and a 25 // A class to manage the lifetime of a MojoProxyResolverImpl and a
24 // HostResolverMojo. An instance will remain while the message pipes for both 26 // HostResolverMojo. An instance will remain while the message pipes for both
25 // mojo connections remain open. 27 // mojo connections remain open.
26 class MojoProxyResolverHolder : public mojo::ErrorHandler { 28 class MojoProxyResolverHolder : public mojo::ErrorHandler {
27 public: 29 public:
28 MojoProxyResolverHolder( 30 MojoProxyResolverHolder(
29 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory, 31 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory,
30 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 32 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
31 interfaces::HostResolverPtr host_resolver); 33 interfaces::HostResolverPtr host_resolver,
34 interfaces::ProxyResolverErrorObserverPtr error_observer);
32 35
33 private: 36 private:
34 // mojo::ErrorHandler override. 37 // mojo::ErrorHandler override.
35 void OnConnectionError() override; 38 void OnConnectionError() override;
36 39
37 void LoadStateChanged(ProxyResolver::RequestHandle handle, 40 void LoadStateChanged(ProxyResolver::RequestHandle handle,
38 LoadState load_state); 41 LoadState load_state);
39 42
40 HostResolverMojo host_resolver_; 43 HostResolverMojo host_resolver_;
41 MojoProxyResolverImpl proxy_resolver_; 44 MojoProxyResolverImpl proxy_resolver_;
42 mojo::Binding<interfaces::ProxyResolver> binding_; 45 mojo::Binding<interfaces::ProxyResolver> binding_;
43 46
44 DISALLOW_COPY_AND_ASSIGN(MojoProxyResolverHolder); 47 DISALLOW_COPY_AND_ASSIGN(MojoProxyResolverHolder);
45 }; 48 };
46 49
47 MojoProxyResolverHolder::MojoProxyResolverHolder( 50 MojoProxyResolverHolder::MojoProxyResolverHolder(
48 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory, 51 const MojoProxyResolverFactoryImpl::Factory& proxy_resolver_factory,
49 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 52 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
50 interfaces::HostResolverPtr host_resolver) 53 interfaces::HostResolverPtr host_resolver,
54 interfaces::ProxyResolverErrorObserverPtr error_observer)
51 : host_resolver_(host_resolver.Pass(), 55 : host_resolver_(host_resolver.Pass(),
52 base::Bind(&MojoProxyResolverHolder::OnConnectionError, 56 base::Bind(&MojoProxyResolverHolder::OnConnectionError,
53 base::Unretained(this))), 57 base::Unretained(this))),
54 proxy_resolver_(proxy_resolver_factory.Run( 58 proxy_resolver_(proxy_resolver_factory.Run(
55 &host_resolver_, 59 &host_resolver_,
60 ProxyResolverErrorObserverMojo::Create(error_observer.Pass()),
56 base::Bind(&MojoProxyResolverHolder::LoadStateChanged, 61 base::Bind(&MojoProxyResolverHolder::LoadStateChanged,
57 base::Unretained(this)))), 62 base::Unretained(this)))),
58 binding_(&proxy_resolver_, request.Pass()) { 63 binding_(&proxy_resolver_, request.Pass()) {
59 binding_.set_error_handler(this); 64 binding_.set_error_handler(this);
60 } 65 }
61 66
62 void MojoProxyResolverHolder::OnConnectionError() { 67 void MojoProxyResolverHolder::OnConnectionError() {
63 delete this; 68 delete this;
64 } 69 }
65 70
(...skipping 15 matching lines...) Expand all
81 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl( 86 MojoProxyResolverFactoryImpl::MojoProxyResolverFactoryImpl(
82 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request) 87 mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request)
83 : MojoProxyResolverFactoryImpl(base::Bind(&CreateDefaultProxyResolver), 88 : MojoProxyResolverFactoryImpl(base::Bind(&CreateDefaultProxyResolver),
84 request.Pass()) { 89 request.Pass()) {
85 } 90 }
86 91
87 MojoProxyResolverFactoryImpl::~MojoProxyResolverFactoryImpl() = default; 92 MojoProxyResolverFactoryImpl::~MojoProxyResolverFactoryImpl() = default;
88 93
89 void MojoProxyResolverFactoryImpl::CreateResolver( 94 void MojoProxyResolverFactoryImpl::CreateResolver(
90 mojo::InterfaceRequest<interfaces::ProxyResolver> request, 95 mojo::InterfaceRequest<interfaces::ProxyResolver> request,
91 interfaces::HostResolverPtr host_resolver) { 96 interfaces::HostResolverPtr host_resolver,
97 interfaces::ProxyResolverErrorObserverPtr error_observer) {
92 // The MojoProxyResolverHolder will delete itself when either |request| or 98 // The MojoProxyResolverHolder will delete itself when either |request| or
93 // |host_resolver| encounters a connection error, that is, when either the 99 // |host_resolver| encounters a connection error, that is, when either the
94 // ProxyResolver client or the HostResolver implementation is deleted. 100 // ProxyResolver client or the HostResolver implementation is deleted.
95 new MojoProxyResolverHolder(proxy_resolver_impl_factory_, request.Pass(), 101 new MojoProxyResolverHolder(proxy_resolver_impl_factory_, request.Pass(),
96 host_resolver.Pass()); 102 host_resolver.Pass(), error_observer.Pass());
97 } 103 }
98 104
99 } // namespace net 105 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698