tools/metrics/actions/actions.xml - Issue 1017443002: Allow users to add third-party VPNs from the settings page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/actions/actions.xml

Issue 1017443002: Allow users to add third-party VPNs from the settings page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_3_460428_update_details_dialog

Patch Set: Fixed typo; rebased. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('K') | « chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/actions/actions.xml

diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml

index eafd69ca9c45864e328648824c45bf9fee61c006..208338ff1b464ec251b0ff7f72d133424cacb9c4 100644

--- a/tools/metrics/actions/actions.xml

+++ b/tools/metrics/actions/actions.xml

@@ -9113,11 +9113,27 @@ should be able to be added at any place in this file.

</description>

</action>

+<action name="Options_NetworkAddVPNBuiltIn">

+ <owner>stevenjb@chromium.org</owner>

+ <description>

+ Settings: Internet connection: VPN dropdown: Show built-in dialog for adding

+ an OpenVPN or T2TP VPN.

+ </description>

+</action>

+<action name="Options_NetworkAddVPNThirdParty">

+ <owner>stevenjb@chromium.org</owner>

+ <description>

+ Settings: Internet connection: VPN dropdown: Show "add network" dialog for a third-party VPN provider.

+ </description>

+</action>

<owner>stevenjb@chromium.org</owner>

Settings: Internet connection: VPN dropdown: Join other

</description>

+ <obsolete>Replaced by Options_NetworkAddVPNBuiltIn.</obsolete>

</action>