chrome/browser/ui/webui/options/chromeos/internet_options_handler.h - Issue 1017443002: Allow users to add third-party VPNs from the settings page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

Issue 1017443002: Allow users to add third-party VPNs from the settings page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_3_460428_update_details_dialog

Patch Set: Fixed closure errors. Addressed comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/chromeos/vpn_providers.js ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

index e09ff0931a7d0d7006abec7429bbaffb49bbf9d9..9ee4b8bebdcfea13c4b4bb725c24ac4e6f1a2dba 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.h

@@ -110,7 +110,8 @@ class InternetOptionsHandler : public ::options::OptionsPageUIHandler,

const PrefService* GetPrefs() const;

// Additional callbacks for managing networks.

- void AddConnection(const base::ListValue* args);

+ void AddVPNConnection(const base::ListValue* args);

+ void AddNonVPNConnection(const base::ListValue* args);

void ConfigureNetwork(const base::ListValue* args);

void ActivateNetwork(const base::ListValue* args);

void RemoveNetwork(const base::ListValue* args);