Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: public/platform/Platform.h

Issue 1017433002: Add RAPPOR metric recording for Device{Orientation,Motion} in blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove debug logging Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/Platform.h
diff --git a/public/platform/Platform.h b/public/platform/Platform.h
index ba29cdc917c98a608e47829834f868a84e89741f..d4e39b86105a28966651e4d58b0249bc1d40feff 100644
--- a/public/platform/Platform.h
+++ b/public/platform/Platform.h
@@ -570,8 +570,12 @@ public:
virtual void histogramEnumeration(const char* name, int sample, int boundaryValue) { }
// Unlike enumeration histograms, sparse histograms only allocate memory for non-empty buckets.
virtual void histogramSparse(const char* name, int sample) { }
- // Record to RAPPOR.
+
+ // Record to RAPPOR, see: https://www.chromium.org/developers/design-documents/rappor
+ // Records a sample string to a Rappor privacy-preserving metric.
virtual void recordRappor(const char* metric, const WebString& sample) { }
+ // Records a domain and registry of a url to a Rappor privacy-preserving metric.
Mike West 2015/04/14 05:20:38 Nit: These method-level comments seem somewhat sel
timvolodine 2015/04/14 10:24:22 I've added these comments on suggestion of koji@ a
+ virtual void recordRapporURL(const char* metric, const blink::WebURL& url) { }
// GPU ----------------------------------------------------------------
//
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698