Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: public/platform/Platform.h

Issue 1017433002: Add RAPPOR metric recording for Device{Orientation,Motion} in blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 // Device Orientation, Device Motion, Device Light, Battery, Gamepad. 599 // Device Orientation, Device Motion, Device Light, Battery, Gamepad.
600 600
601 // Request the platform to start listening to the events of the specified 601 // Request the platform to start listening to the events of the specified
602 // type and notify the given listener (if not null) when there is an update. 602 // type and notify the given listener (if not null) when there is an update.
603 virtual void startListening(WebPlatformEventType type, WebPlatformEventListe ner* listener) { } 603 virtual void startListening(WebPlatformEventType type, WebPlatformEventListe ner* listener) { }
604 604
605 // Request the platform to stop listening to the specified event and no 605 // Request the platform to stop listening to the specified event and no
606 // longer notify the listener, if any. 606 // longer notify the listener, if any.
607 virtual void stopListening(WebPlatformEventType type) { } 607 virtual void stopListening(WebPlatformEventType type) { }
608 608
609 virtual void recordRapporMetric(WebPlatformEventType type, const WebURL& url ) { }
Mike West 2015/03/23 17:27:30 Don't we already have "recordRappor"? Why do we ne
timvolodine 2015/03/23 17:33:30 I understood from holte@ that there is currently n
610
609 // This method converts from the supplied DOM code enum to the 611 // This method converts from the supplied DOM code enum to the
610 // embedder's DOM code value for the key pressed. |domCode| values are 612 // embedder's DOM code value for the key pressed. |domCode| values are
611 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h. 613 // based on the value defined in ui/events/keycodes/dom4/keycode_converter_d ata.h.
612 // Returns null string, if DOM code value is not found. 614 // Returns null string, if DOM code value is not found.
613 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); } 615 virtual WebString domCodeStringFromEnum(int domCode) { return WebString(); }
614 616
615 // This method converts from the suppled DOM code value to the 617 // This method converts from the suppled DOM code value to the
616 // embedder's DOM code enum for the key pressed. |codeString| is defined in 618 // embedder's DOM code enum for the key pressed. |codeString| is defined in
617 // ui/events/keycodes/dom4/keycode_converter_data.h. 619 // ui/events/keycodes/dom4/keycode_converter_data.h.
618 // Returns 0, if DOM code enum is not found. 620 // Returns 0, if DOM code enum is not found.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 protected: 671 protected:
670 BLINK_PLATFORM_EXPORT Platform(); 672 BLINK_PLATFORM_EXPORT Platform();
671 virtual ~Platform() { } 673 virtual ~Platform() { }
672 674
673 WebThread* m_mainThread; 675 WebThread* m_mainThread;
674 }; 676 };
675 677
676 } // namespace blink 678 } // namespace blink
677 679
678 #endif 680 #endif
OLDNEW
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698