Issue 101743002: Add some DVLOG's in MetadataDatabase::Update* methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101743002: Add some DVLOG's in MetadataDatabase::Update* methods (Closed)

Created:
7 years ago by kinuko

Modified:
7 years ago

Reviewers:
tzik

CC:
chromium-reviews, kinuko+watch, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add some DVLOG's in MetadataDatabase::Update* methods BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238395

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -35 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/metadata_database.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/metadata_database.cc	View		5 chunks	+40 lines, -32 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

Can we add some more logs like this? Also UpdateByDeletedRemoteFile doesn't seem to be called ...

7 years ago (2013-12-03 12:28:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/101743002/1

7 years ago (2013-12-03 12:48:07 UTC) #3

Michael van Ouwerkerk

A revert of this CL has been created in https://codereview.chromium.org/102073003/ by mvanouwerkerk@chromium.org. The reason for ...

7 years ago (2013-12-03 15:26:14 UTC) #5

kinuko

7 years ago (2013-12-03 16:04:05 UTC) #6

Message was sent while issue was closed.

On 2013/12/03 15:26:14, Michael van Ouwerkerk wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/102073003/ by
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=mvanouwerkerk@chromium.org.
> 
> The reason for reverting is: Build broken on Chromium Webkit on GPU Win
Builder.

Thanks, it seems to have broken compile on other bots too.  Why CQ doesn't catch
them... :(

Expand Messages | Collapse Messages