Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10174007: Fix shared_memory_posix Map() (Closed)

Created:
8 years, 8 months ago by raymes
Modified:
8 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org, viettrungluu
Visibility:
Public.

Description

mmap returns -1 on failure and in the posix implementation of SharedMemory, this was setting memory_ to -1. However the interface for SharedMemory specifies that memory_ should be NULL if it is unmapped. Furthermore there was DCHECK included to check the success of mmap, but I feel this is incorrect because we are returning the success (e.g. other platform implementations don't do this). The caller can DCHECK if they need. We could change this to a LOG call. BUG=None TEST=out/Debug/base_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/shared_memory_posix.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
8 years, 8 months ago (2012-04-23 16:37:55 UTC) #1
brettw
lgtm
8 years, 8 months ago (2012-04-23 19:24:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/10174007/1
8 years, 8 months ago (2012-04-23 19:31:48 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 21:00:08 UTC) #4
Change committed as 133516

Powered by Google App Engine
This is Rietveld 408576698