Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1017373003: Introduce PaintingContext, which will be used for custom painting (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Introduce PaintingContext, which will be used for custom painting This CL is a first step towards custom paint. It introduces a class that can draw a circle into an SkPicture. Future CLs will wire the SkPicture into the render tree and expose this object to script. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/40cb1cc5b5b1f6290b2ce1b32e353c7ec1a429a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -3 lines) Patch
M sky/engine/core/core.gni View 2 chunks +6 lines, -0 lines 0 comments Download
A sky/engine/core/painting/Paint.h View 1 chunk +45 lines, -0 lines 0 comments Download
A + sky/engine/core/painting/Paint.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
A sky/engine/core/painting/Paint.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A sky/engine/core/painting/PaintingContext.h View 1 chunk +37 lines, -0 lines 0 comments Download
A sky/engine/core/painting/PaintingContext.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
A sky/engine/core/painting/PaintingContext.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-19 00:00:35 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-19 00:06:25 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-19 17:54:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40cb1cc5b5b1f6290b2ce1b32e353c7ec1a429a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698