src/IceELFObjectWriter.cpp - Issue 1017373002: Subzero: Assemble calls to constant addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceELFObjectWriter.cpp

Issue 1017373002: Subzero: Assemble calls to constant addresses. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: move test back Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceELFObjectWriter.cpp

diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp

index 230848c4f2c0a0c3de441e33a102c886f5af78fa..073163a4023ec5513d494d858f856aacb19a4db2 100644

--- a/src/IceELFObjectWriter.cpp

+++ b/src/IceELFObjectWriter.cpp

@@ -84,10 +84,7 @@ ELFObjectWriter::ELFObjectWriter(GlobalContext &Ctx, ELFStreamer &Out)

"Elf_Sym sizes cannot be derived from sizeof");

SymTab = createSection<ELFSymbolTableSection>(SymTabName, SHT_SYMTAB, 0,

SymTabAlign, SymTabEntSize);

- // The first entry in the symbol table should be a NULL entry.

- const IceString NullSymName("");

- SymTab->createDefinedSym(NullSymName, STT_NOTYPE, STB_LOCAL, NullSection, 0,

- 0);

+ SymTab->createNullSymbol(NullSection);

const IceString StrTabName(".strtab");

StrTab =

« no previous file with comments | « src/IceClFlags.h ('k') | src/IceELFSection.h » ('j') | no next file with comments »