Issue 1017353002: Added a positional Component.fromArgs() constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1017353002: Added a positional Component.fromArgs() constructor (Closed)

Created:
5 years, 9 months ago by hansmuller

Modified:
5 years, 9 months ago

Reviewers:
hansmuller1, rafaelw

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Added a positional Component.fromArgs() constructor To define a Component subclass with mixins, a constructor without optional parameters is needed. Added Component.fromArgs() which just delegates to the main constructor. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c08f8ca3d62b0998e4caed5cf74228bb4b9afef1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	sky/framework/fn.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

hansmuller

5 years, 9 months ago (2015-03-19 15:06:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c08f8ca3d62b0998e4caed5cf74228bb4b9afef1 (presubmit successful).