Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1017333002: Rename WebEventHandler to MessageCallback (Closed)

Created:
5 years, 9 months ago by sgurun-gerrit only
Modified:
5 years, 9 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WebEventHandler to MessageCallback Rename WebEventHandler to MessageCallback to be more compatible with other postmessage names. BUG=393291 Committed: https://crrev.com/2a36dbe88541d6dc0e09dc439e548b7b64d80ca7 Cr-Commit-Position: refs/heads/master@{#321235}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M android_webview/java/src/org/chromium/android_webview/MessagePort.java View 1 5 chunks +9 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 12 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sgurun-gerrit only
On 2015/03/18 21:47:45, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:hush@chromium.org PTAL, thanks
5 years, 9 months ago (2015-03-18 21:47:57 UTC) #2
hush (inactive)
lgtm with minor comments https://codereview.chromium.org/1017333002/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java File android_webview/java/src/org/chromium/android_webview/MessagePort.java (right): https://codereview.chromium.org/1017333002/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java#newcode75 android_webview/java/src/org/chromium/android_webview/MessagePort.java:75: * The message callback for ...
5 years, 9 months ago (2015-03-18 22:24:01 UTC) #3
hush (inactive)
On 2015/03/18 22:24:01, hush wrote: > lgtm with minor comments > > https://codereview.chromium.org/1017333002/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java > File ...
5 years, 9 months ago (2015-03-18 22:24:28 UTC) #4
sgurun-gerrit only
https://codereview.chromium.org/1017333002/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java File android_webview/java/src/org/chromium/android_webview/MessagePort.java (right): https://codereview.chromium.org/1017333002/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java#newcode75 android_webview/java/src/org/chromium/android_webview/MessagePort.java:75: * The message callback for receiving messages. Called on ...
5 years, 9 months ago (2015-03-18 22:37:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017333002/20001
5 years, 9 months ago (2015-03-18 22:38:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 23:40:25 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 23:41:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a36dbe88541d6dc0e09dc439e548b7b64d80ca7
Cr-Commit-Position: refs/heads/master@{#321235}

Powered by Google App Engine
This is Rietveld 408576698