[AiS] adding content and answer line heights

[AiS] adding content and answer line heights.

This change adds functions to return the content line height and the answer line height.  It also makes the answer line height the large font.

(Separated out from CL 795933009).

BUG=455418
Committed: https://crrev.com/5feb7557ef12fc616080dda155d8a143ee311375
Cr-Commit-Position: refs/heads/master@{#321269}

[dschuyler, 2015-03-19 00:40:04]

dschuyler@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-03-19 00:54:57]

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right):

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:305: // Source x, y, w,
h.
Nit: I'd probably omit these two comments, but up to you.

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:615:
ui::ResourceBundle::LargeFont));
This doesn't seem right.  Why are we changing the font used for non-answer
descriptions?

[dschuyler, 2015-03-19 01:14:55]

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right):

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:305: // Source x, y, w,
h.
On 2015/03/19 00:54:57, Peter Kasting wrote:
> Nit: I'd probably omit these two comments, but up to you.

I think you'd previously made a suggestion that this take two Rectangle values
as input.  That would be my preference as well.

Done.

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:305: // Source x, y, w,
h.
On 2015/03/19 00:54:57, Peter Kasting wrote:
> Nit: I'd probably omit these two comments, but up to you.

Done.

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:615:
ui::ResourceBundle::LargeFont));
On 2015/03/19 00:54:57, Peter Kasting wrote:
> This doesn't seem right.  Why are we changing the font used for non-answer
> descriptions?

In my testing, this only happens for the AiS results - non AiS descriptions are
not affected.  Is there a situation I may be missing where non-AiS description
render text would be affected?

[Peter Kasting, 2015-03-19 01:17:56]

LGTM

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right):

https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omn...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:615:
ui::ResourceBundle::LargeFont));
On 2015/03/19 01:14:55, dschuyler wrote:
> On 2015/03/19 00:54:57, Peter Kasting wrote:
> > This doesn't seem right.  Why are we changing the font used for non-answer
> > descriptions?
> 
> In my testing, this only happens for the AiS results - non AiS descriptions
are
> not affected.  Is there a situation I may be missing where non-AiS description
> render text would be affected?

Oops, I didn't read the code properly.

I guess this is basically placeholder code until the rest of your original CL
lands.

This is the downside of splitting up CLs: while they're smaller and easier to
review individually, sometimes they have to do temporary things not found in the
original, which adds its own confusion.  I probably wouldn't have split your
original CL given that it was so close to landing, but whatever.  This is fine
as a placeholder.

[dschuyler, 2015-03-19 02:09:09]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2015-03-19 02:09:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017323003/20001

[commit-bot: I haz the power, 2015-03-19 02:12:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 02:13:27]

Patchset 2 (id:??) landed as
https://crrev.com/5feb7557ef12fc616080dda155d8a143ee311375
Cr-Commit-Position: refs/heads/master@{#321269}