Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1017323003: [AiS] adding content and answer line heights (Closed)

Created:
5 years, 9 months ago by dschuyler
Modified:
5 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su, groby-ooo-7-16, Justin Donnelly
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AiS] adding content and answer line heights. This change adds functions to return the content line height and the answer line height. It also makes the answer line height the large font. (Separated out from CL 795933009). BUG=455418 Committed: https://crrev.com/5feb7557ef12fc616080dda155d8a143ee311375 Cr-Commit-Position: refs/heads/master@{#321269}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -28 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 8 chunks +49 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dschuyler
5 years, 9 months ago (2015-03-19 00:40:22 UTC) #2
Peter Kasting
https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode305 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:305: // Source x, y, w, h. Nit: I'd probably ...
5 years, 9 months ago (2015-03-19 00:54:57 UTC) #3
dschuyler
https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode305 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:305: // Source x, y, w, h. On 2015/03/19 00:54:57, ...
5 years, 9 months ago (2015-03-19 01:14:55 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/1017323003/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode615 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:615: ui::ResourceBundle::LargeFont)); On 2015/03/19 01:14:55, dschuyler wrote: > On ...
5 years, 9 months ago (2015-03-19 01:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017323003/20001
5 years, 9 months ago (2015-03-19 02:09:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 02:12:48 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 02:13:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5feb7557ef12fc616080dda155d8a143ee311375
Cr-Commit-Position: refs/heads/master@{#321269}

Powered by Google App Engine
This is Rietveld 408576698