make IsRepeated work even when a KeyEvent is created from the same native event.

This CL should make IsRepeated more robust for a code that needs to create KeyEvent from native code, like key rewriter, or https://codereview.chromium.org/1013003002/

BUG=468442
TEST=covered by test, and also tested manually.

Committed: https://crrev.com/dfd141b02a8ee4dc72c8e1d3dee8ce2d2ca4938d
Cr-Commit-Position: refs/heads/master@{#321378}

[oshima, 2015-03-18 22:25:30]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2015-03-18 22:25:35]

Patchset #1 (id:1) has been deleted

[oshima, 2015-03-18 23:04:24]

please hold. I have to fix a couple of more tests.

[oshima, 2015-03-19 00:37:21]

Patchset #2 (id:40001) has been deleted

[oshima, 2015-03-19 00:46:05]

PTAL

I changed default tick clock for EventGenerator so that KeyEvent always get
different timestamp.

https://codereview.chromium.org/1017323002/diff/60001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/accelerator_controller_browsertest.cc (left):

https://codereview.chromium.org/1017323002/diff/60001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/accelerator_controller_browsertest.cc:42: // drops the
ui::EF_IS_REPEAT flag otherwise.
EventGenerator creates KeyEvent using native event, so this isn't necessary.

https://codereview.chromium.org/1017323002/diff/60001/ui/events/event_unittes...
File ui/events/event_unittest.cc (right):

https://codereview.chromium.org/1017323002/diff/60001/ui/events/event_unittes...
ui/events/event_unittest.cc:427: const uint16 kNativeCodeB =
ui::KeycodeConverter::CodeToNativeKeycode("KeyB");
I though about changing this test to use EventGenerator, but it may be better to
have at least one test that doesn't depend on EventGenerator. Let me know what
you think.

https://codereview.chromium.org/1017323002/diff/80001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/accelerator_controller_browsertest.cc (left):

https://codereview.chromium.org/1017323002/diff/80001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/accelerator_controller_browsertest.cc:42: // drops the
ui::EF_IS_REPEAT flag otherwise.
EventGenerator creates KeyEvent using native event, so this isn't necessary.

https://codereview.chromium.org/1017323002/diff/80001/ui/events/event_unittes...
File ui/events/event_unittest.cc (right):

https://codereview.chromium.org/1017323002/diff/80001/ui/events/event_unittes...
ui/events/event_unittest.cc:427: const uint16 kNativeCodeB =
ui::KeycodeConverter::CodeToNativeKeycode("KeyB");
I though about changing this test to use EventGenerator, but it may be better to
have at least one test that doesn't depend on EventGenerator. Let me know what
you think.

[oshima, 2015-03-19 07:46:26]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-03-19 07:46:28]

The CQ bit was unchecked by oshima@chromium.org

[sadrul, 2015-03-19 10:36:53]

lgtm

https://codereview.chromium.org/1017323002/diff/80001/ui/events/event_unittes...
File ui/events/event_unittest.cc (right):

https://codereview.chromium.org/1017323002/diff/80001/ui/events/event_unittes...
ui/events/event_unittest.cc:427: const uint16 kNativeCodeB =
ui::KeycodeConverter::CodeToNativeKeycode("KeyB");
On 2015/03/19 00:46:04, oshima wrote:
> I though about changing this test to use EventGenerator, but it may be better
to
> have at least one test that doesn't depend on EventGenerator. Let me know what
> you think. 

Sounds good.

https://codereview.chromium.org/1017323002/diff/80001/ui/events/test/event_ge...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/1017323002/diff/80001/ui/events/test/event_ge...
ui/events/test/event_generator.cc:45: int64 ticks_ = 1;
Oh, does the style guide allow this?

[oshima, 2015-03-19 16:41:57]

https://codereview.chromium.org/1017323002/diff/80001/ui/events/test/event_ge...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/1017323002/diff/80001/ui/events/test/event_ge...
ui/events/test/event_generator.cc:45: int64 ticks_ = 1;
On 2015/03/19 10:36:53, sadrul wrote:
> Oh, does the style guide allow this?

Yep, see "Non-Static Class Member Initializers" in
https://chromium-cpp.appspot.com/

[oshima, 2015-03-19 16:42:23]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-03-19 16:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017323002/80001

[commit-bot: I haz the power, 2015-03-19 16:46:04]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-03-19 16:47:48]

Patchset 3 (id:??) landed as
https://crrev.com/dfd141b02a8ee4dc72c8e1d3dee8ce2d2ca4938d
Cr-Commit-Position: refs/heads/master@{#321378}