Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/codec/SkCodec.cpp

Issue 1017293002: guarded change to SkImageGenerator to make getInfo() const (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/codec/SkCodec.cpp
diff --git a/src/codec/SkCodec.cpp b/src/codec/SkCodec.cpp
index d557087c01879f257fd64a2d8e7400cce920b765..eab85fcfd345991c543e04aadc2cf7c04b5e959d 100644
--- a/src/codec/SkCodec.cpp
+++ b/src/codec/SkCodec.cpp
@@ -45,8 +45,8 @@ SkCodec* SkCodec::NewFromData(SkData* data) {
return NewFromStream(SkNEW_ARGS(SkMemoryStream, (data)));
}
-SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream)
- : fInfo(info)
+SkCodec::SkCodec(const SkImageInfo& info, SkStream* stream) : INHERITED(info)
scroggo 2015/03/19 13:27:47 nit: Shouldn't this go on the next line?
reed1 2015/03/19 15:20:46 Done.
+ , fInfo(info)
scroggo 2015/03/19 13:27:47 fInfo is no longer needed by SkCodec. We can inste
reed1 2015/03/19 15:20:46 I thought I would remove the (many) duplicates in
, fStream(stream)
, fNeedsRewind(false)
{}

Powered by Google App Engine
This is Rietveld 408576698