Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1017263004: [New Multicolumn] Give up on stretching columns if they have already reached max height. (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Give up on stretching columns if they have already reached max height. This doesn't change any behavior (column heights were already clamped against max height), but it avoids an assertion failure that would occur if no space shortage is recorded during a layout pass. Unbreakable content (lines) that's taller than the column (max) height don't record space shortage, as columns cannot be stretched beyond the (max) height anyway. Note that layout might end up looking somewhat weird in situations like this, since content that's supposed to be unbreakable is split across multiple columns (instead of letting content overflow columns in the block direction). For paged overflow (or printing) this is the desired behavior, though, since overflow will be clipped. See also crbug.com/367651 This also avoids the same assertion failure when fast/block/line-layout/line-break-removal-near-textarea-crash.html is run with the new multicol implementation on Mac, because -webkit-appearance:button imposes a min-height there. min-height is treated as height if height is auto. That's crbug.com/65731 BUG=470527 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/unbreakable-content-taller-than-height-crash-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-25 20:08:53 UTC) #1
eae
Makes sense to me, Julien/Dan do you have any concerns about this approach?
5 years, 8 months ago (2015-03-26 21:17:38 UTC) #2
dsinclair
lgtm
5 years, 8 months ago (2015-03-26 21:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017263004/1
5 years, 8 months ago (2015-03-26 21:23:10 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-26 23:11:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192636

Powered by Google App Engine
This is Rietveld 408576698