Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1017263003: Properly handle non-JSFunction constructors in CanRetainOtherContext (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Igor Sheludko, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly handle non-JSFunction constructors in CanRetainOtherContext BUG= Committed: https://crrev.com/1b16678f25823f0a2b46f9ca78ac50052198121f Cr-Commit-Position: refs/heads/master@{#27379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/type-info.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-filter-contexts.js View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-23 18:55:39 UTC) #2
Igor Sheludko
lgtm
5 years, 9 months ago (2015-03-23 18:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017263003/1
5 years, 9 months ago (2015-03-23 19:00:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:24:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:25:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b16678f25823f0a2b46f9ca78ac50052198121f
Cr-Commit-Position: refs/heads/master@{#27379}

Powered by Google App Engine
This is Rietveld 408576698