Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1017193004: Improve the openning animation for PopupMenu (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve the openning animation for PopupMenu We're now doing all of the elements of the popup menu entrance animation from the material design spec, but our timing and curves might not be exactly right yet. I haven't started on the exit animation. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7214b7ec7d27563b2666afad86cf1c5895c56c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -28 lines) Patch
M sky/examples/stocks-fn/lib/stock_app.dart View 6 chunks +12 lines, -7 lines 0 comments Download
M sky/examples/stocks-fn/lib/stock_menu.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sky/framework/components/popup_menu.dart View 1 chunk +73 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-18 22:15:45 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-18 22:19:53 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-18 22:21:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7214b7ec7d27563b2666afad86cf1c5895c56c18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698