chrome/browser/banners/app_banner_manager.h - Issue 1017193002: [App banners] Be less strict about navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1017193002: [App banners] Be less strict about navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/banners/app_banner_manager.h

diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h

index d20acccf2290e6f2779af9174d04b8bc001bffb0..020c559f3b6c4ce9b22b5541ac6abb5da9bf31f2 100644

--- a/chrome/browser/banners/app_banner_manager.h

+++ b/chrome/browser/banners/app_banner_manager.h

@@ -33,6 +33,9 @@ class AppBannerManager : public content::WebContentsObserver,

static bool IsEnabled();

static void DisableSecureSchemeCheckForTesting();

+ // Returns whether or not the URLs match for everything except for the ref.

+ static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);

explicit AppBannerManager(int icon_size);

~AppBannerManager() override;