Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/banners/app_banner_settings_helper_unittest.cc

Issue 1017193002: [App banners] Be less strict about navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move annotation upwards Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_settings_helper_unittest.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper_unittest.cc b/chrome/browser/banners/app_banner_settings_helper_unittest.cc
index e744c0eb8fa7343a279fd70c443318708c45491a..92a6562a844b03c8956ae058bb2a77f7971a1596 100644
--- a/chrome/browser/banners/app_banner_settings_helper_unittest.cc
+++ b/chrome/browser/banners/app_banner_settings_helper_unittest.cc
@@ -35,20 +35,6 @@ class AppBannerSettingsHelperTest : public ChromeRenderViewHostTestHarness {};
} // namespace
-TEST_F(AppBannerSettingsHelperTest, Block) {
- GURL url(kTestURL);
- NavigateAndCommit(url);
-
- // Check that by default, showing the banner is allowed.
- EXPECT_TRUE(AppBannerSettingsHelper::IsAllowed(web_contents(), url,
- kTestPackageName));
-
- // Block the banner and test it is no longer allowed.
- AppBannerSettingsHelper::Block(web_contents(), url, kTestPackageName);
- EXPECT_FALSE(AppBannerSettingsHelper::IsAllowed(web_contents(), url,
- kTestPackageName));
-}
-
TEST_F(AppBannerSettingsHelperTest, CouldShowEvents) {
GURL url(kTestURL);
NavigateAndCommit(url);

Powered by Google App Engine
This is Rietveld 408576698