chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java - Issue 1017193002: [App banners] Be less strict about navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1017193002: [App banners] Be less strict about navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move annotation upwards Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

index df485b0eb2b3edae7c1cbd11c5891f7d26ea076f..a947b56f11dbaec9f0c1f9cb91a86b0c473a48fb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

@@ -133,10 +133,10 @@ public class AppBannerManager extends EmptyTabObserver {

};

}

- /** Enables the app banners for testing. */

+ /** Enables or disables the app banners for testing. */

@VisibleForTesting

- static void setIsEnabledForTesting() {

- sIsEnabled = true;

+ static void setIsEnabledForTesting(boolean state) {

+ sIsEnabled = state;

}

/** Sets a constant (in days) that gets added to the time when the current time is requested. */