[App banners] Be less strict about navigations

chrome/browser/banners/app_banner_data_fetcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_data_fetcher.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/manifest/manifest_icon_selector.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/render_messages.h"
 #include "components/infobars/core/infobar.h"
 #include "components/rappor/rappor_utils.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/service_worker_context.h"
 #include "content/public/browser/storage_partition.h"
 #include "net/base/load_flags.h"
 #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h"
 #include "ui/gfx/screen.h"
 
 namespace {
 
 base::TimeDelta gTimeDeltaForTesting;
@@ skipping 76 matching lines @@
 }
 
 void AppBannerDataFetcher::WebContentsDestroyed() {
   Cancel();
   Observe(nullptr);
 }
 
 void AppBannerDataFetcher::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
-  Cancel();
+  if (!details.is_in_page)
+    Cancel();
 }
 
 bool AppBannerDataFetcher::OnMessageReceived(
     const IPC::Message& message, content::RenderFrameHost* render_frame_host) {
   bool handled = true;
 
   IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(AppBannerDataFetcher, message,
                                    render_frame_host)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AppBannerPromptReply,
                         OnBannerPromptReply)
@@ skipping 213 matching lines @@
   if (!manifest.start_url.is_valid())
     return false;
   if (manifest.name.is_null() && manifest.short_name.is_null())
     return false;
   if (!DoesManifestContainRequiredIcon(manifest))
     return false;
   return true;
 }
 
 }  // namespace banners