Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1017183004: Revert of Unflake V8 sampling profiler tests. (Closed)

Created:
5 years, 9 months ago by pneubeck (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
alph, yurys
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/) Reason for revert: Broke compilation on Mac Builder: https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc Original issue's description: > Unflake V8 sampling profiler tests. > > BUG=406277 > > Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95 > Cr-Commit-Position: refs/heads/master@{#321970} TBR=yurys@chromium.org,alph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406277 Committed: https://crrev.com/3703085199a63732add21d955c6280765e3c480e Cr-Commit-Position: refs/heads/master@{#321975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -26 lines) Patch
M content/renderer/devtools/v8_sampling_profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 6 chunks +5 lines, -19 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pneubeck (no reviews)
Created Revert of Unflake V8 sampling profiler tests.
5 years, 9 months ago (2015-03-24 11:51:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017183004/1
5 years, 9 months ago (2015-03-24 11:51:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 11:51:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3703085199a63732add21d955c6280765e3c480e Cr-Commit-Position: refs/heads/master@{#321975}
5 years, 9 months ago (2015-03-24 11:52:23 UTC) #4
alph
5 years, 9 months ago (2015-03-24 12:14:48 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1029353002/ by alph@chromium.org.

The reason for reverting is: Suspecting goma flake. Relanding..

Powered by Google App Engine
This is Rietveld 408576698