Make DOMTypedArray exported.

Source/core/dom/DOMTypedArray.cpp

Index: Source/core/dom/DOMTypedArray.cpp
diff --git a/Source/core/dom/DOMTypedArray.cpp b/Source/core/dom/DOMTypedArray.cpp
index ec4d1c7a9aabae4552bc3c47b7fbc9d6194f432c..7f0d8d6968d8bf4c989e6c97b47b94cc531bf158 100644
--- a/Source/core/dom/DOMTypedArray.cpp
+++ b/Source/core/dom/DOMTypedArray.cpp
@@ -57,4 +57,15 @@ INSTANTIATE_DOMTYPEDARRAY_MEMBER_FUNCTIONS(Float64);
 #undef INSTANTIATE_DOMTYPEDARRAY_MEMBER_FUNCTIONS
 #undef INSTANTIATE_DOMTYPEDARRAY_MEMBER_FUNCTIONS_IMPL
 
+template PassRefPtr<DOMTypedArray<WTF::Int8Array, v8::Int8Array>> DOMTypedArray<WTF::Int8Array, v8::Int8Array>::create(unsigned length);
+template PassRefPtr<DOMTypedArray<WTF::Int8Array, v8::Int8Array>> DOMTypedArray<WTF::Int8Array, v8::Int8Array>::create(const WTF::Int8Array::ValueType*, unsigned length);

[tasak, 2015/03/19 11:17:24]

Since WTF::Int8Array doesn't have createOrNull, the following compile error
occurrs if instantiating class DOMTypedArray<WTF::Int8Array, v8::Int8Array>>:

c:\src\blink\local\workspace0\src\third_party\webkit\source\core\dom\domtypedarray.h(56)
: error C2783: 'WTF::PassRefPtr<U> WTF::TypedArrayBase<T>::createOrNull(unsigned
int)' : could not deduce template argument for 'Subclass'
        with
        [
            T=unsigned char
        ]
       
c:\src\blink\local\workspace0\src\third_party\webkit\source\wtf\typedarraybase.h(121)
: see declaration of 'WTF::TypedArrayBase<T>::createOrNull'
        with
        [
            T=unsigned char
        ]
       
c:\src\blink\local\workspace0\src\third_party\webkit\source\core\dom\domtypedarray.h(55)
: while compiling class template member function
'WTF::PassRefPtr<blink::DOMTypedArray<WTF::Uint8Array,v8::Uint8Array>>
blink::DOMTypedArray<WTF::Uint8Array,v8::Uint8Array>::createOrNull(unsigned
int)'
       
c:\src\blink\local\workspace0\src\third_party\webkit\source\core\dom\domtypedarray.cpp(50)
: see reference to class template instantiation
'blink::DOMTypedArray<WTF::Uint8Array,v8::Uint8Array>' being compiled
ninja: build stopped: subcommand failed.

[Yuki, 2015/03/19 11:56:02]

It seems we have two options.

1. Add WTF::Int8Array::createOrNull.
The implementation will be ASSERT_NOT_REACHED() + return nullptr;
Someone (likely me) needs to clean up WTF::ArrayBuffer family anyway,
so leave it to him.

2. Remove DOMTypedArray::createOrNull.
It seems DOMTypedArray::createOrNull is used only at two places:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
So, inline the implementation of DOMTypedArray::createOrNull there.
I think it's not so bad.  Maybe better than option 1.

I'm okay with either of the above options.

[tasak, 2015/03/20 04:34:47]

I would like to instantiate template in per-method manner, because I found the
following compiler warnings when I tried option 1 or option2:

third_party\webkit\source\core\dom\domtypedarray.cpp(40) : warning C4661: 'const
blink::WrapperTypeInfo
&blink::DOMTypedArray<WTF::Int8Array,v8::Int8Array>::s_wrapperTypeInfo' : no
suitable definition provided for explicit template instantiation request
        third_party\webkit\source\core\dom\domtypedarray.h(26) : see declaration
of 'blink::DOMTypedArray<WTF::Int8Array,v8::Int8Array>::s_wrapperTypeInfo'
...

If we want to instantiate DOMTypedArray<> classes, we need suitable
s_wrapperTypeInfo definitions in DOMTypedArray.cpp. But the s_wrapperTypeInfo
are defined in generated binding code.

+
+template PassRefPtr<DOMTypedArray<WTF::Uint8Array, v8::Uint8Array>> DOMTypedArray<WTF::Uint8Array, v8::Uint8Array>::create(unsigned length);
+template PassRefPtr<DOMTypedArray<WTF::Uint8Array, v8::Uint8Array>> DOMTypedArray<WTF::Uint8Array, v8::Uint8Array>::create(const WTF::Uint8Array::ValueType*, unsigned length);
+template WTF::Uint8Array::ValueType* DOMTypedArray<WTF::Uint8Array, v8::Uint8Array>::data() const;
+
+template PassRefPtr<DOMTypedArray<WTF::Float32Array, v8::Float32Array>> DOMTypedArray<WTF::Float32Array, v8::Float32Array>::createOrNull(unsigned length);
+template bool DOMTypedArray<WTF::Float32Array, v8::Float32Array>::zeroRange(unsigned offset, size_t length);
+template bool DOMTypedArray<WTF::Float32Array, v8::Float32Array>::setRange(const DOMTypedArray<WTF::Float32Array, v8::Float32Array>::ValueType* data, size_t dataLength, unsigned offset);
+
 } // namespace blink