Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1017163002: [Android] Add ring_buffer option to adb.Logcat (Closed)

Created:
5 years, 9 months ago by perezju
Modified:
5 years, 9 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add ring_buffer option to adb.Logcat We can use this option, e.g., to request only the "crash" portion of a logcat. BUG= Committed: https://crrev.com/d642544d7ac9987fb728c0251ae2587ec3b07bc5 Cr-Commit-Position: refs/heads/master@{#321324}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/android/pylib/device/adb_wrapper.py View 3 chunks +8 lines, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
perezju
This one should be a should be a simple one. Adds support for the logcat ...
5 years, 9 months ago (2015-03-18 16:49:51 UTC) #2
jbudorick
lgtm w/ optional nit https://codereview.chromium.org/1017163002/diff/1/build/android/pylib/device/adb_wrapper.py File build/android/pylib/device/adb_wrapper.py (right): https://codereview.chromium.org/1017163002/diff/1/build/android/pylib/device/adb_wrapper.py#newcode335 build/android/pylib/device/adb_wrapper.py:335: if ring_buffer: optional nit: could ...
5 years, 9 months ago (2015-03-18 16:53:01 UTC) #3
perezju
On 2015/03/18 16:53:01, jbudorick wrote: > lgtm w/ optional nit > > https://codereview.chromium.org/1017163002/diff/1/build/android/pylib/device/adb_wrapper.py > File ...
5 years, 9 months ago (2015-03-19 09:00:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017163002/1
5 years, 9 months ago (2015-03-19 09:00:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 10:06:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:07:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d642544d7ac9987fb728c0251ae2587ec3b07bc5
Cr-Commit-Position: refs/heads/master@{#321324}

Powered by Google App Engine
This is Rietveld 408576698