Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 1017103003: MIPS: Disinherit PropertyCell from Cell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 __ mov(v0, scratch1); 187 __ mov(v0, scratch1);
188 } 188 }
189 189
190 190
191 // Generate code to check that a global property cell is empty. Create 191 // Generate code to check that a global property cell is empty. Create
192 // the property cell at compilation time if no cell exists for the 192 // the property cell at compilation time if no cell exists for the
193 // property. 193 // property.
194 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 194 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
195 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 195 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
196 Register scratch, Label* miss) { 196 Register scratch, Label* miss) {
197 Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 197 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
198 DCHECK(cell->value()->IsTheHole()); 198 DCHECK(cell->value()->IsTheHole());
199 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell); 199 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);
200 __ LoadWeakValue(scratch, weak_cell, miss); 200 __ LoadWeakValue(scratch, weak_cell, miss);
201 __ ld(scratch, FieldMemOperand(scratch, Cell::kValueOffset)); 201 __ ld(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
202 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 202 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
203 __ Branch(miss, ne, scratch, Operand(at)); 203 __ Branch(miss, ne, scratch, Operand(at));
204 } 204 }
205 205
206 206
207 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 207 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
208 Register holder, Register name, 208 Register holder, Register name,
209 Handle<JSObject> holder_obj) { 209 Handle<JSObject> holder_obj) {
210 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0); 210 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0);
211 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 1); 211 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 1);
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 // Return the generated code. 740 // Return the generated code.
741 return GetCode(kind(), Code::NORMAL, name); 741 return GetCode(kind(), Code::NORMAL, name);
742 } 742 }
743 743
744 744
745 #undef __ 745 #undef __
746 } 746 }
747 } // namespace v8::internal 747 } // namespace v8::internal
748 748
749 #endif // V8_TARGET_ARCH_MIPS64 749 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698