Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 1017103003: MIPS: Disinherit PropertyCell from Cell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 __ mov(v0, scratch1); 186 __ mov(v0, scratch1);
187 } 187 }
188 188
189 189
190 // Generate code to check that a global property cell is empty. Create 190 // Generate code to check that a global property cell is empty. Create
191 // the property cell at compilation time if no cell exists for the 191 // the property cell at compilation time if no cell exists for the
192 // property. 192 // property.
193 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 193 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
194 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 194 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
195 Register scratch, Label* miss) { 195 Register scratch, Label* miss) {
196 Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 196 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
197 DCHECK(cell->value()->IsTheHole()); 197 DCHECK(cell->value()->IsTheHole());
198 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell); 198 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);
199 __ LoadWeakValue(scratch, weak_cell, miss); 199 __ LoadWeakValue(scratch, weak_cell, miss);
200 __ lw(scratch, FieldMemOperand(scratch, Cell::kValueOffset)); 200 __ lw(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
201 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 201 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
202 __ Branch(miss, ne, scratch, Operand(at)); 202 __ Branch(miss, ne, scratch, Operand(at));
203 } 203 }
204 204
205 205
206 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 206 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
207 Register holder, Register name, 207 Register holder, Register name,
208 Handle<JSObject> holder_obj) { 208 Handle<JSObject> holder_obj) {
209 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0); 209 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0);
210 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 1); 210 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsThisIndex == 1);
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 // Return the generated code. 739 // Return the generated code.
740 return GetCode(kind(), Code::NORMAL, name); 740 return GetCode(kind(), Code::NORMAL, name);
741 } 741 }
742 742
743 743
744 #undef __ 744 #undef __
745 } 745 }
746 } // namespace v8::internal 746 } // namespace v8::internal
747 747
748 #endif // V8_TARGET_ARCH_MIPS 748 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698