Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1017063002:
V8 Sampling Profiler: Collect V8 sample trace events on Linux and MacOS (Closed)
|
Created:
5 years, 9 months ago by alph Modified:
5 years, 9 months ago CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pfeldman, yurys Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionV8 Sampling Profiler: Collect V8 sample trace events on Linux and MacOS
When the v8.cpu_profiler tracing category is enabled
it starts generating V8Sample events with stack frames and
V8 state.
LockFreeCircularQueue template is taken from V8.
Android and Windows support will be coming.
BUG=406277
Committed: https://crrev.com/cc35222c027b300b2edb95c7bcb6db02ab95da4c
Cr-Commit-Position: refs/heads/master@{#321565}
Patch Set 1 #
Total comments: 10
Patch Set 2 : addressing comments. #Patch Set 3 : add #include "base/atomicops.h" #Patch Set 4 : Fix Win build. #Patch Set 5 : Disable tests on Win and Android #
Messages
Total messages: 25 (9 generated)
alph@chromium.org changed reviewers: + loislo@chromium.org, yurys@chromium.org
General comment: let's keep parts that depend on content/ abstractions separate from those that depend on v8 only. The latter should eventually be moved into its own component that can be reused be other embedders. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... File content/renderer/devtools/v8_sampling_profiler.cc (right): https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:8: #include <signal.h> You'll likely need <ucontext.h> and <mach/mach.h> too. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:42: class SamplingCircularQueue { Let's move it in a separate file. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:265: tls_instance_.Pointer()->Set(nullptr); It is not safe to access TLS storage in signal handler. We should come up with something smarter than this. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:304: LOG(ERROR) << "No space left in the sampling buffer"; I'm pretty much sure it will allocate. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:437: static bool signal_handler_installed_; Should be behind #ifdef
alph@chromium.org changed reviewers: + jochen@chromium.org, nduca@chromium.org
@jochen Could you please approve the content/content_renderer.gypi change. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... File content/renderer/devtools/v8_sampling_profiler.cc (right): https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:8: #include <signal.h> On 2015/03/18 12:49:03, yurys wrote: > You'll likely need <ucontext.h> and <mach/mach.h> too. It compiles so far. I'll add these includes when it fails. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:42: class SamplingCircularQueue { On 2015/03/18 12:49:04, yurys wrote: > Let's move it in a separate file. Done. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:265: tls_instance_.Pointer()->Set(nullptr); On 2015/03/18 12:49:03, yurys wrote: > It is not safe to access TLS storage in signal handler. We should come up with > something smarter than this. It should be safe provided that: - the tls variable is already allocated/initialized - the signal handler only reads the variable. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:304: LOG(ERROR) << "No space left in the sampling buffer"; On 2015/03/18 12:49:04, yurys wrote: > I'm pretty much sure it will allocate. Acknowledged. https://codereview.chromium.org/1017063002/diff/1/content/renderer/devtools/v... content/renderer/devtools/v8_sampling_profiler.cc:437: static bool signal_handler_installed_; On 2015/03/18 12:49:03, yurys wrote: > Should be behind #ifdef Done.
lgtm
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017063002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org Link to the patchset: https://codereview.chromium.org/1017063002/#ps60001 (title: "Fix Win build.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017063002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by alph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org Link to the patchset: https://codereview.chromium.org/1017063002/#ps80001 (title: "Disable tests on Win and Android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017063002/80001
lgtm
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/cc35222c027b300b2edb95c7bcb6db02ab95da4c Cr-Commit-Position: refs/heads/master@{#321565}
Message was sent while issue was closed.
On 2015/03/20 13:59:24, I haz the power (commit-bot) wrote: > Patchset 5 (id:??) landed as > https://crrev.com/cc35222c027b300b2edb95c7bcb6db02ab95da4c > Cr-Commit-Position: refs/heads/master@{#321565} This change has broken ChromeOS build for nyan-big.
Message was sent while issue was closed.
On 2015/03/20 16:19:58, Steve McKay wrote: > On 2015/03/20 13:59:24, I haz the power (commit-bot) wrote: > > Patchset 5 (id:??) landed as > > https://crrev.com/cc35222c027b300b2edb95c7bcb6db02ab95da4c > > Cr-Commit-Position: refs/heads/master@{#321565} > > This change has broken ChromeOS build for nyan-big. I suppose some details would be helpful: [71/1206] CXX obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o FAILED: /media/smckay/chromium_ssd/.cros_cache/common/goma+2/gomacc armv7a-cros-linux-gnueabi-g++ -B/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.24-gold -MMD -MF obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o.d -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=231690-1 -DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_SECCOMP_BPF -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DUSE_V4L2_CODEC -DSK_SUPPORT_GPU=1 -DSK_LEGACY_DRAWPICTURECALLBACK -DSK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DPOSIX -DWEBRTC_POSIX -DCHROMEOS -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/WebKit -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/iccjpeg -I../../third_party/libjpeg -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/libyuv/include -I../../third_party/libyuv -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/modules/audio_device/include -I../../net/third_party/nss/ssl -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -Wno-unused-local-typedefs -pthread -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/glib-2.0 -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib/glib-2.0/include -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/build/nyan/usr/include/freetype2 -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/freetype2 -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr -march=armv7-a -mtune=generic-armv7-a -mfpu=neon -mfloat-abi=hard -mthumb --sysroot=/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -g -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -gsplit-dwarf -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -c ../../content/renderer/devtools/v8_sampling_profiler.cc -o obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o ../../content/renderer/devtools/v8_sampling_profiler.cc: In static member function 'static void content::V8SamplingThread::HandleProfilerSignal(int, siginfo_t*, void*)': ../../content/renderer/devtools/v8_sampling_profiler.cc:469:47: error: 'mcontext_t' has no member named 'gregs' state.pc = reinterpret_cast<void*>(mcontext.gregs[REG_EIP]); ^ ../../content/renderer/devtools/v8_sampling_profiler.cc:469:53: error: 'REG_EIP' was not declared in this scope state.pc = reinterpret_cast<void*>(mcontext.gregs[REG_EIP]); ^ ../../content/renderer/devtools/v8_sampling_profiler.cc:470:47: error: 'mcontext_t' has no member named 'gregs' state.sp = reinterpret_cast<void*>(mcontext.gregs[REG_ESP]); ^ ../../content/renderer/devtools/v8_sampling_profiler.cc:470:53: error: 'REG_ESP' was not declared in this scope state.sp = reinterpret_cast<void*>(mcontext.gregs[REG_ESP]); ^ ../../content/renderer/devtools/v8_sampling_profiler.cc:471:47: error: 'mcontext_t' has no member named 'gregs' state.fp = reinterpret_cast<void*>(mcontext.gregs[REG_EBP]); ^ ../../content/renderer/devtools/v8_sampling_profiler.cc:471:53: error: 'REG_EBP' was not declared in this scope state.fp = reinterpret_cast<void*>(mcontext.gregs[REG_EBP]); ^ [71/1206] CXX obj/content/common/content_common.content_message_generator.o ninja: build stopped: subcommand failed.
Message was sent while issue was closed.
On 2015/03/20 16:20:32, Steve McKay wrote: > On 2015/03/20 16:19:58, Steve McKay wrote: > > On 2015/03/20 13:59:24, I haz the power (commit-bot) wrote: > > > Patchset 5 (id:??) landed as > > > https://crrev.com/cc35222c027b300b2edb95c7bcb6db02ab95da4c > > > Cr-Commit-Position: refs/heads/master@{#321565} > > > > This change has broken ChromeOS build for nyan-big. > > I suppose some details would be helpful: > > [71/1206] CXX > obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o > FAILED: /media/smckay/chromium_ssd/.cros_cache/common/goma+2/gomacc > armv7a-cros-linux-gnueabi-g++ > -B/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.24-gold > -MMD -MF obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o.d > -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 > -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=231690-1 -DENABLE_RLZ > -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 > -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_DEFAULT_RENDER_THEME=1 > -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 > -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY > -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 > -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 > -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 > -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 > -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 > -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 > -DUSE_SECCOMP_BPF -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL > -DLIBPEERCONNECTION_LIB=1 -DUSE_V4L2_CODEC -DSK_SUPPORT_GPU=1 > -DSK_LEGACY_DRAWPICTURECALLBACK -DSK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS > -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DU_USING_ICU_NAMESPACE=0 > -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL > -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH > -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DPOSIX > -DWEBRTC_POSIX -DCHROMEOS -DWEBRTC_CHROMIUM_BUILD -DUSE_LIBPCI=1 -DUSE_GLIB=1 > -DUSE_NSS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS > -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND > -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. > -I../../skia/config -I../../third_party/WebKit/Source > -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit > -I../../third_party/mojo/src -Igen/third_party/mojo/src > -I../../third_party/skia/include/core -I../../third_party/skia/include/effects > -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu > -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops > -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports > -I../../third_party/skia/include/utils -I../../skia/ext > -I../../third_party/WebKit -I../../third_party/libpng -I../../third_party/zlib > -I../../third_party/libwebp -I../../third_party/ots/include > -I../../third_party/qcms/src -I../../third_party/iccjpeg > -I../../third_party/libjpeg -I../../third_party/icu/source/i18n > -I../../third_party/icu/source/common -I../../third_party/webrtc/overrides > -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source > -I../../testing/gtest/include -I../../third_party -I../../third_party/npapi > -I../../third_party/npapi/bindings -I../../v8/include > -I../../third_party/libyuv/include -I../../third_party/libyuv > -I../../third_party/webrtc/modules/interface > -I../../third_party/webrtc/modules/audio_device/include > -I../../net/third_party/nss/ssl -Werror -pthread -fno-strict-aliasing -Wall > -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe > -fPIC -g -Wno-unused-local-typedefs -pthread > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/glib-2.0 > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib/glib-2.0/include > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/build/nyan/usr/include/freetype2 > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/freetype2 > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss > -I/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr > -march=armv7-a -mtune=generic-armv7-a -mfpu=neon -mfloat-abi=hard -mthumb > --sysroot=/media/smckay/chromium_ssd/.cros_cache/chrome-sdk/tarballs/nyan_big+6871.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz > -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables > -fno-asynchronous-unwind-tables -g -pipe -march=armv7-a -mtune=cortex-a15 > -mfpu=neon -mfloat-abi=hard -D__google_stl_debug_vector=1 -gsplit-dwarf > -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden > -Wsign-compare -Wno-abi -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -c > ../../content/renderer/devtools/v8_sampling_profiler.cc -o > obj/content/renderer/devtools/content_renderer.v8_sampling_profiler.o > ../../content/renderer/devtools/v8_sampling_profiler.cc: In static member > function 'static void content::V8SamplingThread::HandleProfilerSignal(int, > siginfo_t*, void*)': > ../../content/renderer/devtools/v8_sampling_profiler.cc:469:47: error: > 'mcontext_t' has no member named 'gregs' > state.pc = reinterpret_cast<void*>(mcontext.gregs[REG_EIP]); > ^ > ../../content/renderer/devtools/v8_sampling_profiler.cc:469:53: error: 'REG_EIP' > was not declared in this scope > state.pc = reinterpret_cast<void*>(mcontext.gregs[REG_EIP]); > ^ > ../../content/renderer/devtools/v8_sampling_profiler.cc:470:47: error: > 'mcontext_t' has no member named 'gregs' > state.sp = reinterpret_cast<void*>(mcontext.gregs[REG_ESP]); > ^ > ../../content/renderer/devtools/v8_sampling_profiler.cc:470:53: error: 'REG_ESP' > was not declared in this scope > state.sp = reinterpret_cast<void*>(mcontext.gregs[REG_ESP]); > ^ > ../../content/renderer/devtools/v8_sampling_profiler.cc:471:47: error: > 'mcontext_t' has no member named 'gregs' > state.fp = reinterpret_cast<void*>(mcontext.gregs[REG_EBP]); > ^ > ../../content/renderer/devtools/v8_sampling_profiler.cc:471:53: error: 'REG_EBP' > was not declared in this scope > state.fp = reinterpret_cast<void*>(mcontext.gregs[REG_EBP]); > ^ > [71/1206] CXX obj/content/common/content_common.content_message_generator.o > ninja: build stopped: subcommand failed. Same issue on Cast-team's Linux ARM builds (internal). Looks like ARM architectures are not accounted for. Steve or alph@: are you looking into fixing this?
Message was sent while issue was closed.
Hopefully fixed with https://codereview.chromium.org/1025753003/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
