Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: Source/core/frame/DOMWindowLifecycleObserver.h

Issue 1017043002: Remove all event listeners during window's frame destruction step. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve LocalDOMWindow::dispose() comment a bit Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2013 Google Inc. All Rights Reserved. 3 * Copyright (C) 2013 Google Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 19 matching lines...) Expand all
30 #include "core/frame/LocalDOMWindow.h" 30 #include "core/frame/LocalDOMWindow.h"
31 #include "platform/LifecycleObserver.h" 31 #include "platform/LifecycleObserver.h"
32 #include "wtf/text/WTFString.h" 32 #include "wtf/text/WTFString.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 class DOMWindowLifecycleNotifier; 36 class DOMWindowLifecycleNotifier;
37 37
38 class DOMWindowLifecycleObserver : public LifecycleObserver<LocalDOMWindow, DOMW indowLifecycleObserver, DOMWindowLifecycleNotifier> { 38 class DOMWindowLifecycleObserver : public LifecycleObserver<LocalDOMWindow, DOMW indowLifecycleObserver, DOMWindowLifecycleNotifier> {
39 public: 39 public:
40 virtual void contextDestroyed()
41 {
42 didRemoveAllEventListeners(lifecycleContext());
43 LifecycleObserver<LocalDOMWindow, DOMWindowLifecycleObserver, DOMWindowL ifecycleNotifier>::contextDestroyed();
44 }
45 virtual void didAddEventListener(LocalDOMWindow*, const AtomicString&) { } 40 virtual void didAddEventListener(LocalDOMWindow*, const AtomicString&) { }
46 virtual void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) { } 41 virtual void didRemoveEventListener(LocalDOMWindow*, const AtomicString&) { }
47 virtual void didRemoveAllEventListeners(LocalDOMWindow*) { } 42 virtual void didRemoveAllEventListeners(LocalDOMWindow*) { }
48 43
49 protected: 44 protected:
50 explicit DOMWindowLifecycleObserver(LocalDOMWindow*); 45 explicit DOMWindowLifecycleObserver(LocalDOMWindow*);
51 virtual ~DOMWindowLifecycleObserver(); 46 virtual ~DOMWindowLifecycleObserver();
52 }; 47 };
53 48
54 } // namespace blink 49 } // namespace blink
55 50
56 #endif // DOMWindowLifecycleObserver_h 51 #endif // DOMWindowLifecycleObserver_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698