Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 101703004: Add chrome_elf_unittests to chromium_builder_tests and chrome_elf to All (Closed)

Created:
7 years ago by csharp
Modified:
7 years ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add chrome_elf_unittests to chromium_builder_tests and chrome_elf to All This will ensure that the bots build the elf tests as expected, and that all Chrome elf targets are part of All. R=caitkp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239806

Patch Set 1 #

Patch Set 2 : Add elf to all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csharp
7 years ago (2013-12-09 16:24:03 UTC) #1
csharp
Added chrome_elf.gyp:* to All as well.
7 years ago (2013-12-09 19:50:45 UTC) #2
Cait (Slow)
lgtm -- thanks Chris!
7 years ago (2013-12-09 21:48:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/101703004/20001
7 years ago (2013-12-10 16:03:14 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-10 18:27:48 UTC) #5
Message was sent while issue was closed.
Change committed as 239806

Powered by Google App Engine
This is Rietveld 408576698