Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 101693004: Move remaining core/platform/mac files to platform/mac (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move remaining core/platform/mac files to platform/mac BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164401

Patch Set 1 #

Patch Set 2 : Add to whitelist in proper location #

Patch Set 3 : Make platformTheme mac only #

Patch Set 4 : Fix compile problem #

Patch Set 5 : Retry fixing the compile problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -845 lines) Patch
M Source/core/core.gyp View 1 2 chunks +0 lines, -48 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/platform/mac/ThemeMac.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/platform/mac/ThemeMac.mm View 1 chunk +0 lines, -728 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 2 chunks +1 line, -1 line 0 comments Download
M Source/platform/Theme.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/mac/ThemeMac.h View 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/mac/ThemeMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rwlbuis
Should be straightforward. I did have to export the platformTheme, which seems only used by ...
6 years, 11 months ago (2013-12-31 15:11:19 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2013-12-31 17:19:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/101693004/160001
6 years, 11 months ago (2013-12-31 17:47:44 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2013-12-31 18:57:04 UTC) #4
Message was sent while issue was closed.
Change committed as 164401

Powered by Google App Engine
This is Rietveld 408576698