Replace UTF16 string with UTF8 string in the |WebsiteSettings| class.

Replace UTF16 string with UTF8 string in the |WebsiteSettings| class. This safes unnecessary conversions from UTF8 to UTF16 to UTF8.

See http://codereview.chromium.org/10163002/ 

BUG=113688
TEST=

[markusheintz_, 2012-04-20 11:54:46]

Please review this CL. Thanks.

[Finnur, 2012-04-20 12:52:53]

There is no bug and no description. What is the impetus for this?

I actually don't know why these were string16 to begin with. Maybe wtc knows?

The TEST= should probably be to view a website info for some chinese website (or
whatever) and make sure you don't see garbled info, or something...

[markusheintz_, 2012-04-20 13:35:06]

I guess I know now why this is done. And close this CL.

Sorry.

[wtc, 2012-04-20 18:17:06]

I don't remember why the strings in this class are
UTF-16 string.  Markus, since you figured it out,
do you think it is worth adding a comment to to explain
why?

[markusheintz_, 2012-04-23 09:14:53]

On 2012/04/20 18:17:06, wtc wrote:
> I don't remember why the strings in this class are
> UTF-16 string.  Markus, since you figured it out,
> do you think it is worth adding a comment to to explain
> why?

The (string16 typed) strings are displayed in the UI and this is probably the
reason why they are all UTF16 strings.

For the GTK UI I need to convert the UTF16 strings to UTF8 strings. So I thought
(ignoring the views UI) I could safe some UTF string conversions. In order to
avoid unnecessary UTF string conversions I think about moving the (UI) string
creation from website_settings.cc to website_settings_popup_*.cc.

This seemed like a low hanging fruit but I will leave it as it is for now as I
have to many pressing tasks with a higher priority.

I will add some comment, saying that these strings will be displayed in the UI.