Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1016873002: Record forced alternative service histogram. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record forced alternative service histogram. This is to track force-alt-protocols command line flag usage to be able to decide whether it should be kept. BUG=452514 Committed: https://crrev.com/a0d2ac651f2ccfd3daaa9f9b7bd593e95da04808 Cr-Commit-Position: refs/heads/master@{#321246}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Extend histogram description based on rch's suggestion. #

Total comments: 1

Patch Set 3 : Add enum BooleanForced. #

Patch Set 4 : MSVC doesn't like implicit pointer to bool conversion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M net/http/http_server_properties_impl.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Bence
Ryan, PTAL. It seems like https://crrev.com/879863004 does not work at all, I will revert it, ...
5 years, 9 months ago (2015-03-17 19:31:28 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1016873002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1016873002/diff/1/tools/metrics/histograms/histograms.xml#newcode17723 tools/metrics/histograms/histograms.xml:17723: + <summary>Track force-alt-protocols command line flag usage.</summary> Might ...
5 years, 9 months ago (2015-03-17 19:40:41 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1016873002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1016873002/diff/1/tools/metrics/histograms/histograms.xml#newcode17723 tools/metrics/histograms/histograms.xml:17723: + <summary>Track force-alt-protocols command line flag usage.</summary> On ...
5 years, 9 months ago (2015-03-17 19:46:31 UTC) #4
Bence
Alexei, PTAL. Thank you.
5 years, 9 months ago (2015-03-17 19:46:51 UTC) #6
Alexei Svitkine (slow)
lgtm % comment https://codereview.chromium.org/1016873002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1016873002/diff/20001/tools/metrics/histograms/histograms.xml#newcode17721 tools/metrics/histograms/histograms.xml:17721: +<histogram name="Net.ForceAlternativeService" enum="Boolean"> Nit: enum="BooleanForced" - ...
5 years, 9 months ago (2015-03-17 23:12:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016873002/60001
5 years, 9 months ago (2015-03-18 16:05:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/65336)
5 years, 9 months ago (2015-03-18 16:39:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016873002/80001
5 years, 9 months ago (2015-03-18 20:20:32 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 9 months ago (2015-03-19 00:15:39 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 00:16:36 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a0d2ac651f2ccfd3daaa9f9b7bd593e95da04808
Cr-Commit-Position: refs/heads/master@{#321246}

Powered by Google App Engine
This is Rietveld 408576698