Source/core/style/ComputedStyle.h - Issue 1016863002: Fix integer overflow in ComputedStyle::computedLineHeight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/style/ComputedStyle.h

Issue 1016863002: Fix integer overflow in ComputedStyle::computedLineHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash2-expected.txt ('k') | Source/core/style/ComputedStyle.cpp » ('j') | Source/core/style/ComputedStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/style/ComputedStyle.h

diff --git a/Source/core/style/ComputedStyle.h b/Source/core/style/ComputedStyle.h

index 117eb9acff7061d06b03cf4cd9f82a48bec7634d..f8a81e1e68bf5dacd82946711174a4bfb2308181 100644

--- a/Source/core/style/ComputedStyle.h

+++ b/Source/core/style/ComputedStyle.h

@@ -588,7 +588,7 @@ public:

const Length& specifiedLineHeight() const;

Length lineHeight() const;

- int computedLineHeight() const;

+ LayoutUnit computedLineHeight() const;

EWhiteSpace whiteSpace() const { return static_cast<EWhiteSpace>(inherited_flags._white_space); }

static bool autoWrap(EWhiteSpace ws)