LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash2.html - Issue 1016863002: Fix integer overflow in ComputedStyle::computedLineHeight

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash2.html

Issue 1016863002: Fix integer overflow in ComputedStyle::computedLineHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Clamp explicitly Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash-expected.txt ('k') | LayoutTests/fast/shapes/shape-outside-floats/shape-outside-line-height-crash2-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 * {

	4 shape-outside: radial-gradient(circle, green 0px, transparent 40px);

	5 font: normal small-caps bold calc( 9946% / -8855 + 9312 * 1774% )/calc( 9946 % / -8855 + 9312 * 1774% ) sans-serif;

	6 float: right;

	7 }

	8 </style>

	9 <body>

	10 <p>This test passes if it doesn't crash.</p>

	11 </body>

	12 <script>

	13 if (window.testRunner)

	14 testRunner.dumpAsText();

	15 </script>

OLD	NEW