Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1016813004: Revert of Add ZipReader::ExtractCurrentEntry with a delegate interface. (Closed)

Created:
5 years, 9 months ago by benwells
Modified:
5 years, 9 months ago
Reviewers:
hshi1, grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ZipReader::ExtractCurrentEntry with a delegate interface. (patchset #2 id:40001 of https://codereview.chromium.org/1014653002/) Reason for revert: There are uninitialized reads on the DrMemory bots in zlib ZipTests. They have very little information, and there is no history available due to a bot problem. Experimentally reverting this CL to see if it helps. Original issue's description: > Add ZipReader::ExtractCurrentEntry with a delegate interface. > > This change gives consumers of ZipReader a way to have the current entry > streamed to them via a Delegate interface. It also: > > - Reduces duplication in the ExtractCurrentEntry* functions. > - Uses the heap rather than the stack for intermediate buffers. > - Changes ExtractCurrentEntryToFd to ExtractCurrentEntryToFile, making > it cross-platform in the process. > > BUG=462584 > > Committed: https://crrev.com/2919be01ff758875fc7161f6b41f4461518c1213 > Cr-Commit-Position: refs/heads/master@{#320948} TBR=hshi@chromium.org,grt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462584 Committed: https://crrev.com/1369bc06458c9e803307ddc7aaec0d71e4a938ab Cr-Commit-Position: refs/heads/master@{#321059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -324 lines) Patch
M third_party/zlib/google/zip_reader.h View 5 chunks +8 lines, -49 lines 0 comments Download
M third_party/zlib/google/zip_reader.cc View 7 chunks +93 lines, -167 lines 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 6 chunks +6 lines, -108 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Add ZipReader::ExtractCurrentEntry with a delegate interface.
5 years, 9 months ago (2015-03-18 02:31:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016813004/1
5 years, 9 months ago (2015-03-18 02:31:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 02:32:19 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 02:33:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1369bc06458c9e803307ddc7aaec0d71e4a938ab
Cr-Commit-Position: refs/heads/master@{#321059}

Powered by Google App Engine
This is Rietveld 408576698