Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1016783004: Revert of Revert of Revert of Revert of Disable a test that fails under ASan and MSan (Closed)

Created:
5 years, 9 months ago by benwells
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Revert of Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1014183002/) Reason for revert: The problem still exists. Reverting this revert^3. Original issue's description: > Revert of Revert of Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1011083002/) > > Reason for revert: > Seems like the underlying problem should now be fixed. Reverting the reverted revert, so the end state should be that the test is no longer disabled. Will look out for problems on the bots. > > Original issue's description: > > Revert of Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1018443002/) > > > > Reason for revert: > > The underlying issue is still not fixed, re-enabling the test causes bots to turn red. > > > > Please wait for the underlying issue to be resolved before re-enabling. > > > > Original issue's description: > > > Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1007293002/) > > > > > > Reason for revert: > > > This test is a victim of a bigger issue of main renderer message loop being used after it is deleted. Details are in crbug.com/467369. > > > > > > I've also run the test with ASAN locally and didn't reproduce after a few runs. > > > > > > Original issue's description: > > > > Disable a test that fails under ASan and MSan > > > > > > > > It can be flaky in other configurations as well > > > > > > > > BUG=467483 > > > > TBR=nasko > > > > > > > > Committed: https://crrev.com/992ff715f61e90562983139ac31392b72e716822 > > > > Cr-Commit-Position: refs/heads/master@{#320713} > > > > > > TBR=timurrrr@chromium.org > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=467483 > > > > > > Committed: https://crrev.com/216981c97018a8b8dea097cbde58889bf4e68c1a > > > Cr-Commit-Position: refs/heads/master@{#320755} > > > > TBR=nasko@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=467483 > > > > Committed: https://crrev.com/186c9ac9e0bc352e0971923584ca3ae26491ece0 > > Cr-Commit-Position: refs/heads/master@{#320890} > > TBR=nasko@chromium.org,timurrrr@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=467483 > > Committed: https://crrev.com/58167ebbb84499812f67ca93ad587048d3004214 > Cr-Commit-Position: refs/heads/master@{#321053} TBR=nasko@chromium.org,timurrrr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467483 Committed: https://crrev.com/579b83f666e818e382c18fe8a7f18a4d6b9b5116 Cr-Commit-Position: refs/heads/master@{#321083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Revert of Revert of Revert of Disable a test that fails under ...
5 years, 9 months ago (2015-03-18 06:23:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016783004/1
5 years, 9 months ago (2015-03-18 06:23:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 06:24:12 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 06:24:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/579b83f666e818e382c18fe8a7f18a4d6b9b5116
Cr-Commit-Position: refs/heads/master@{#321083}

Powered by Google App Engine
This is Rietveld 408576698