Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1016753003: Edited comments for NESTABLE_ASYNC events (Closed)

Created:
5 years, 9 months ago by xunjieli
Modified:
5 years, 9 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, erikwright+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Edited comments for NESTABLE_ASYNC events The documentation for NESTABLE_ASYNC events is not quite right. It does not say that we use "id" to match events, and it is not accurate about the parsing rule for unmatched events. This CL makes changes to the comments, so it will be clearer to future users of the API. Committed: https://crrev.com/f84110e6fe66416fa79a9b3136c1ee5a02941e43 Cr-Commit-Position: refs/heads/master@{#320952}

Patch Set 1 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M base/trace_event/trace_event.h View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xunjieli
5 years, 9 months ago (2015-03-17 16:21:05 UTC) #3
dsinclair
lgtm
5 years, 9 months ago (2015-03-17 17:51:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016753003/20001
5 years, 9 months ago (2015-03-17 17:52:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-17 19:12:11 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 19:13:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f84110e6fe66416fa79a9b3136c1ee5a02941e43
Cr-Commit-Position: refs/heads/master@{#320952}

Powered by Google App Engine
This is Rietveld 408576698