Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1016743002: Adding helper function to check for correct application name (Closed)

Created:
5 years, 9 months ago by shreeramk
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding helper function to check for correct application name. This CL adds a helper function so as to make correct check for application name to stop recurse into applications other than chrome. BUG=none NOTRY=true Committed: https://crrev.com/ec46f6eeaef09ce584846a3d9573649f9c4882a0 Cr-Commit-Position: refs/heads/master@{#321086}

Patch Set 1 #

Patch Set 2 : Adding helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/accessibility/dump_accessibility_tree_auralinux.py View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please take a look. Thanks!!
5 years, 9 months ago (2015-03-17 13:07:59 UTC) #2
dmazzoni
Actually I did that on purpose because I want to catch both "Chrome" and "Chromium". ...
5 years, 9 months ago (2015-03-17 15:39:37 UTC) #3
shreeramk
On 2015/03/17 15:39:37, dmazzoni wrote: > Actually I did that on purpose because I want ...
5 years, 9 months ago (2015-03-18 05:48:00 UTC) #4
dmazzoni
lgtm
5 years, 9 months ago (2015-03-18 06:42:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016743002/20001
5 years, 9 months ago (2015-03-18 06:42:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 06:42:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 06:43:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec46f6eeaef09ce584846a3d9573649f9c4882a0
Cr-Commit-Position: refs/heads/master@{#321086}

Powered by Google App Engine
This is Rietveld 408576698