Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1016693002: Disabling failing tests in WebRtcApprtcBrowserTest (Closed)

Created:
5 years, 9 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 9 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling failing tests in WebRtcApprtcBrowserTest. These tests will be enabled again once the AppRTC app is working again which we expect will happen rather soon. TBR=phoglund BUG=467471 Committed: https://crrev.com/15103a5ff0f262c85309d4b6af957d7c089aab3d Cr-Commit-Position: refs/heads/master@{#320883}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
phoglund_chromium
lgtm, but refer to the right bug in the comment. https://codereview.chromium.org/1016693002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/1016693002/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode235 ...
5 years, 9 months ago (2015-03-17 08:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016693002/20001
5 years, 9 months ago (2015-03-17 08:39:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 09:26:41 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/15103a5ff0f262c85309d4b6af957d7c089aab3d Cr-Commit-Position: refs/heads/master@{#320883}
5 years, 9 months ago (2015-03-17 09:27:09 UTC) #7
kjellander_chromium
5 years, 9 months ago (2015-03-20 06:45:35 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1027673002/ by kjellander@chromium.org.

The reason for reverting is: We have landed an update to the AppRTC app in
https://codereview.chromium.org/1023683002/ now, so these tests should now
work..

Powered by Google App Engine
This is Rietveld 408576698